> On Jan. 19, 2017, 1:35 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, > > line 153 > > <https://reviews.apache.org/r/55717/diff/1/?file=1608974#file1608974line153> > > > > Since the path is fixed (not a pattern), why is `glob.glob` needed?
removed - Renjith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55717/#review162277 ----------------------------------------------------------- On Jan. 19, 2017, 3:58 p.m., Renjith Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55717/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 3:58 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19627 > https://issues.apache.org/jira/browse/AMBARI-19627 > > > Repository: ambari > > > Description > ------- > > Hive is a dependency only for Spark ThriftServer, not for other Spark > components or Zeppelin. Yet, Zeppelin fails to start if Hive is not installed: > > Error: > resource_management.core.exceptions.Fail: > StaticFile('/etc/spark/conf/hive-site.xml') Source file > /etc/spark/conf/hive-site.xml is not found > > > This review is for branch-2.5 patch. There is a separate patch attached in > jira for trunk. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > ac56aa2 > > Diff: https://reviews.apache.org/r/55717/diff/ > > > Testing > ------- > > tested on CentOS and passed unit tests on trunk > > > Thanks, > > Renjith Kamath > >
