> On Jan. 19, 2017, 8:29 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 285 > > <https://reviews.apache.org/r/55692/diff/1/?file=1608511#file1608511line285> > > > > Please don't hard code HDP version, add a stack feature instead (say > > hive_interactive_ga). > > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
Done. - Swapan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55692/#review162255 ----------------------------------------------------------- On Jan. 19, 2017, 10:40 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55692/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 10:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-19616 > https://issues.apache.org/jira/browse/AMBARI-19616 > > > Repository: ambari > > > Description > ------- > > (1). Set 'metaspacesize' based on LLAP daemon size > If LLAP DamoneSize <= 4GB > ---> Don't set metaspacesize > else if LLAP DaemonsSize <=32GB > ---> Set to 256m > else > ---> Set to 1024m (current value) > > (2). Fix for using "--slider-placement" argument only for HDP 2.6 and onwards. > - Current code add it irrespective of HDP version '--slider-placement' is not > valid for option for HDP version less than 2.6. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 6895e34 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 8035be7 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 9185f78 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 6801d5a > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml > 6a68335 > > Diff: https://reviews.apache.org/r/55692/diff/ > > > Testing > ------- > > Yes, on cluster. > > > Thanks, > > Swapan Shridhar > >
