----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55756/#review162409 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Jan. 20, 2017, 11:27 a.m., Andriy Babiichuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55756/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 11:27 a.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-19644 > https://issues.apache.org/jira/browse/AMBARI-19644 > > > Repository: ambari > > > Description > ------- > > When adding a service or deleting a service and configuration changes will be > performed, we currently show a link that the user can optionally click on to > show the changes. > The user can easily miss this, so let's automatically show the config changes > rather than having the user click. > > For Delete Service, we can make the UX consistent with like the one for > adding component to host. > For Add Service, we can force the configuration changes to be popped up upon > clicking Next from Customize Services page. > > > Diffs > ----- > > ambari-web/app/controllers/main/service/item.js 96dd700 > ambari-web/app/controllers/wizard/step7_controller.js 61fd910 > ambari-web/app/templates/main/service/info/delete_service_warning_popup.hbs > 4155947 > ambari-web/test/controllers/wizard/step7_test.js d6f2b00 > > Diff: https://reviews.apache.org/r/55756/diff/ > > > Testing > ------- > > 20309 passing (21s) > 153 pending > > > Thanks, > > Andriy Babiichuk > >
