----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55755/#review162422 -----------------------------------------------------------
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java (line 37) <https://reviews.apache.org/r/55755/#comment233752> we should keep the actual behavior in case of the hadoop auth property does not exists. at least keep it on logsearch side. (it would be the best if we still write the password into a file on ambari side as well if the specific auth is not there) ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java (line 84) <https://reviews.apache.org/r/55755/#comment233753> we can use config.set here as well instead of addResource, then its not needed to create a new xml file, you can get the value from logsearch.properties (or from env variable) - Oliver Szabo On Jan. 20, 2017, 10:42 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55755/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 10:42 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Nahappan > Somasundaram. > > > Bugs: AMBARI-19645 > https://issues.apache.org/jira/browse/AMBARI-19645 > > > Repository: ambari > > > Description > ------- > > Use the Credential Store API to access the truststore / keystore passwords so > they can not be read from any text file. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java > ea9f45d > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > 2fb4ff3 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml > fb641a8 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml > a6f1502 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 432bd58 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 7f502d7 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > a04618f > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 08d3d9d > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py > 1c79c5c > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > f63cd42 > ambari-server/src/test/python/stacks/2.4/configs/default.json dd8a096 > > Diff: https://reviews.apache.org/r/55755/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
