-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55817/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
Bugs: AMBARI-19618
https://issues.apache.org/jira/browse/AMBARI-19618
Repository: ambari
Description
-------
Cohosted components information now is hardcoded in stack_service_component.js
as following:
App.StackServiceComponent.coHost =
{ 'WEBHCAT_SERVER': 'HIVE_SERVER' };
It's better to move them from javascript to metainfom.xml by adding tag
<coHost></coHost>in stack like following:
//HIVE
<component>
<name>WEBHCAT_SERVER</name>
<displayName>WebHCat Server</displayName>
<category>MASTER</category>
<cardinality>1</cardinality>
<versionAdvertised>true</versionAdvertised>
<reassignAllowed>true</reassignAllowed>
<coHost>HIVE_SERVER</coHost>
</component>
//RANGER https://issues.apache.org/jira/browse/AMBARI-19557
<component>
<name>RANGER_USERSYNC</name>
<displayName>Ranger Usersync</displayName>
<category>MASTER</category>
<cardinality>1</cardinality>
<versionAdvertised>true</versionAdvertised>
<coHost>RANGER_ADMIN</coHost>
</component>
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceComponentResponse.java
2f42313
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceComponentResourceProvider.java
c731641
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
51d9847
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java
409bcae
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml
4ba3cf1
ambari-server/src/main/resources/common-services/RANGER/0.4.0/metainfo.xml
a9db470
ambari-server/src/main/resources/properties.json 698b6c5
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
6e2190b
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
6e37ded
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
87a1fc7
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/metainfo.xml
3224eac
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/RANGER/metainfo.xml
PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/HIVE/metainfo.xml
edc5dfb
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/RANGER/metainfo.xml
PRE-CREATION
ambari-web/app/mappers/stack_service_mapper.js 21c4db9
ambari-web/app/models/stack_service_component.js eb6f2db
ambari-web/test/mappers/stack_service_mapper_test.js 9da8b24
ambari-web/test/service_components.js bcc4a29
Diff: https://reviews.apache.org/r/55817/diff/
Testing
-------
1.Ambari Web Unit Tests:
20307 passing (35s)
153 pending
2.Ambari Server Unit Tests:
Failed tests:
ViewRegistryTest.testReadViewArchives:239->testReadViewArchives:466
expected:<DEPLOYED> but was:<ERROR>
ViewRegistryTest.testReadViewArchives_removeUndeployed:244->testReadViewArchives:466
expected:<DEPLOYED> but was:<ERROR>
ViewRegistryTest.testReadViewArchives_viewAutoInstanceCreation:254->testReadViewArchives:466
expected:<DEPLOYED> but was:<ERROR>
Tests run: 4417, Failures: 3, Errors: 0, Skipped: 30
3.Installed a cluster using RPM based on latest trunk codes and screenshots
attached in https://issues.apache.org/jira/browse/AMBARI-19618 show the
expected result.
Thanks,
yao lei
