> On Jan. 23, 2017, 7:26 a.m., Sebastian Toader wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java, > > line 129 > > <https://reviews.apache.org/r/55821/diff/1/?file=1611635#file1611635line129> > > > > Isn't this an error that should be signaled wuth an Exception since the > > password file is provided?
my guess here we should not stop logfeeder in case of ssl is wrongly configured (e.g.: https is enabled for metrics, therefore publishing metrics wont work, but logfeeder can still send data for solr) - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55821/#review162602 ----------------------------------------------------------- On Jan. 22, 2017, 6:57 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55821/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2017, 6:57 p.m.) > > > Review request for Ambari, Robert Nettleton and Sebastian Toader. > > > Bugs: AMBARI-19645 > https://issues.apache.org/jira/browse/AMBARI-19645 > > > Repository: ambari > > > Description > ------- > > the patch is based by https://reviews.apache.org/r/55755/ > first part: support credential store api on logsearch part (originally > developed by Miklos Gergely) > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java > ea9f45d > ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 645c5f0 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java > 2fb4ff3 > > Diff: https://reviews.apache.org/r/55821/diff/ > > > Testing > ------- > > done > > > Thanks, > > Oliver Szabo > >
