----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55838/#review162614 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Jan. 23, 2017, 11:33 a.m., Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55838/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 11:33 a.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-19672 > https://issues.apache.org/jira/browse/AMBARI-19672 > > > Repository: ambari > > > Description > ------- > > {{App.showAlertPopup}} shows popup with some message in the its body and on > button - "Primary". Click on it execute passed callback (if it exists). > Clicking on "x" or "Esc"-press closes modal without callback execution. > Since this modal is not a confirmation-modal (we have > {{App.showConfirmationPopup}}), any interaction with it (click "Ok", press > "Esc", click "x") should execute passed callback. > > > Diffs > ----- > > ambari-web/app/views/common/modal_popups/alert_popup.js 413d33c > > Diff: https://reviews.apache.org/r/55838/diff/ > > > Testing > ------- > > 20467 tests complete (31 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
