----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55845/#review162632 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py (lines 164 - 172) <https://reviews.apache.org/r/55845/#comment233978> This is the heart of the change: if in an upgrade, make sure to link to the new JARs. ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py (line 97) <https://reviews.apache.org/r/55845/#comment233979> This is wrong and just backwards. We set METADATA_HOME_DIR / METADATA_CONF via the Atlas environment shell script file: ``` # metadata configuration directory 115 export METADATA_CONF={{conf_dir}} ``` Ambari should never use a path from the environment, especially because it would prevent this bug from being fixed. If the environment home parameter is fixed, then we can never override the value when creating new JARs - Jonathan Hurley On Jan. 23, 2017, 9:58 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55845/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 9:58 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas. > > > Bugs: AMBARI-19677 > https://issues.apache.org/jira/browse/AMBARI-19677 > > > Repository: ambari > > > Description > ------- > > The {{extlib}} directory of Storm, which is managed by Ambari WRT things like > Atlas hook JARs, must be updated during an upgrade to point to the correct > versions of the JAR files. > > # Deploy HDP-2.5.0.0 cluster with Ambari-2.5.0.0 (2.5.0.0-694) - secure > cluster via Blueprint > # Perform HOU to 2.5.3.0 and let it complete > # Run Storm service check > > > During the upgrade, the pointers are changed to `current` of Atlas which > still points to the old JARs: > > ``` > [root@r6-mams-ambari-re2-7 storm]# ls -lahrt > /usr/hdp/2.5.3.0-38/storm/extlib/ > total 16K > drwxr-xr-x. 12 root root 4.0K Jan 20 06:03 .. > lrwxrwxrwx. 1 root root 81 Jan 20 07:08 > storm-bridge-shim-0.7.0.2.5.0.0-1245.jar -> > /usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim-0.7.0.2.5.0.0-1245.jar > lrwxrwxrwx. 1 root root 88 Jan 20 07:08 > atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar -> > /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.0.0-1245.jar > drwxr-xr-x. 2 root root 4.0K Jan 20 07:08 . > ``` > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py > eeae4bc > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > c74d046 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py > 1fd1b9b > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 70caaea > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > d667d9f > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 137f29a > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > e97759b > ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py bbaef78 > > Diff: https://reviews.apache.org/r/55845/diff/ > > > Testing > ------- > > - Performed an upgrade and downgrade with Storm/Atlas and verified that the > symlinks are correctly created on upgrade and reset properly on downgrade. > - Also, verified that a restart after the upgrade has completed correctly > resets the pointers to `current`: > 2017-01-23 14:40:49,970 - Atlas Server is present on this host, will symlink > jars inside of /usr/hdp/current/storm-nimbus/extlib to > /usr/hdp/current/atlas-server/hook/storm if not already done. > ``` > 2017-01-23 14:40:49,970 - > Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'] > {'to': > '/usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'} > 2017-01-23 14:40:49,971 - > Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'] > replacing old symlink to > /usr/hdp/2.5.2.0-67/atlas/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar > 2017-01-23 14:40:49,973 - Creating symbolic > Link['/usr/hdp/current/storm-nimbus/extlib/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar'] > to > /usr/hdp/current/atlas-server/hook/storm/atlas-plugin-classloader-0.7.0.2.5.2.0-67.jar > 2017-01-23 14:40:49,973 - > Link['/usr/hdp/current/storm-nimbus/extlib/storm-bridge-shim-0.7.0.2.5.2.0-67.jar'] > {'to': '/usr/hdp/current/atlas-server/hook/storm/storm-bridge-shim- > ``` > > ---------------------------------------------------------------------- > Total run:1159 > Total errors:0 > Total failures:0 > OK > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 54.824 s > [INFO] Finished at: 2017-01-23T09:57:20-05:00 > [INFO] Final Memory: 19M/245M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
