----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55842/#review162633 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java (lines 130 - 132) <https://reviews.apache.org/r/55842/#comment233980> I think we tend to try to say away from this notation. How about something like ``` map = propertiesToSet.get("cluster-env") if(map == null) { map = new HashMap<>(); propertiesToSet.put("cluster-env", map); } map.put("security_enabled", security_enabled); ``` - Robert Levas On Jan. 23, 2017, 8:24 a.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55842/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 8:24 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-19675 > https://issues.apache.org/jira/browse/AMBARI-19675 > > > Repository: ambari > > > Description > ------- > > Regenerate keytabs apply all configs but not security_enabled. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java > 931806d > > Diff: https://reviews.apache.org/r/55842/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Eugene Chekanskiy > >
