----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55919/#review162931 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Jan. 25, 2017, 10:03 a.m., Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55919/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 10:03 a.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: ambari-19703 > https://issues.apache.org/jira/browse/ambari-19703 > > > Repository: ambari > > > Description > ------- > > * Open configs for any service > * Go to any custom category > * Click "Add Property" > * Select not bulk mode (name/value should be separated input-fields) > * Set Key to "abc" and Value to "123" > * Click "Add" > * New config is added > * Click "Add Property" again > * Select not bulk mode (it should be already selected anyway) > * Set Key to "abc" > * Error "This property is already defined in this configuration file" is shown > * "Find property" link is shown too > * Click on it > > *ER* "Add Property" modal is closed and configs are filtered with "abc" > *AR* JS-error appears and popup is not hidden > > {noformat} > Uncaught TypeError: Cannot read property 'onClose' of null > {noformat} > > > Diffs > ----- > > ambari-web/app/views/common/configs/service_configs_by_category_view.js > 4148197 > > Diff: https://reviews.apache.org/r/55919/diff/ > > > Testing > ------- > > 20474 tests complete (30 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
