----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55934/#review162987 -----------------------------------------------------------
Fix it, then Ship it! ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (line 139) <https://reviews.apache.org/r/55934/#comment234366> This should have an else? ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py (line 85) <https://reviews.apache.org/r/55934/#comment234364> formatting. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py (line 313) <https://reviews.apache.org/r/55934/#comment234367> Wouldn't this throw KeyError in non-kerberized env? - Sid Wagle On Jan. 25, 2017, 4:09 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55934/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 4:09 p.m.) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-17898 > https://issues.apache.org/jira/browse/AMBARI-17898 > > > Repository: ambari > > > Description > ------- > > This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to > authenticate". > In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari > Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But > Ambari Metrics Monitor, a client of Ambari Metrics Collector, currently does > not support Kerberos HTTP SPNEGO authentication. > /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out: > 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: > http://metrics-collector:6188/ws/v1/timeline/metrics > 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to > server. HTTP Error 401: Authentication required > 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ... > > > Diffs > ----- > > ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini > e98c65c > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py > 7010187 > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py > ba3f18e > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/krberr.py > PRE-CREATION > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py > PRE-CREATION > > ambari-metrics/ambari-metrics-host-monitoring/src/test/python/core/TestEmitter.py > 4056ae3 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json > 51f541f > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > 740a91a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > c3bc600 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 37babff > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2 > 3823912 > > Diff: https://reviews.apache.org/r/55934/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
