-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55981/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-19723
https://issues.apache.org/jira/browse/AMBARI-19723
Repository: ambari
Description
-------
If Log Search portal uses SSL only for solr (no https protocol is set for the
portal, or to communicate with ambari) then it's not working, as nothing
enforces the keystore / truststore passwords to load. Loading these passwords
should not be enforced only by loading the SSLContext, it should be done if
there is a keystrore / truststore location specified - i.e. the portal uses SSL.
Also done some refactoring:
- moved file operations to FileUtil from LogSearch
- moved keystore createion to SSLUtil from LogSearch
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
88cc8bb
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/FileUtil.java
f7330fa
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
e0111e7
Diff: https://reviews.apache.org/r/55981/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
