----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55996/#review163178 -----------------------------------------------------------
Ship it! Ship It! - Sumit Mohanty On Jan. 26, 2017, 9:04 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55996/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 9:04 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-19732 > https://issues.apache.org/jira/browse/AMBARI-19732 > > > Repository: ambari > > > Description > ------- > > Right now zk quorum is read from daemon configs. > > We should also allow override non-default property. > > HadoopMetricsSink, FlumeMetricsSink, already have a template property that is > use only by the AMS Sink. These changes cover the rest. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > 9bc3be5 > > ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java > 5892599 > > ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java > 95e5ba1 > > ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java > 9329aae > > ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java > 3c5655f > > Diff: https://reviews.apache.org/r/55996/diff/ > > > Testing > ------- > > mvn clean test ... passed > > > Thanks, > > Sid Wagle > >
