> On Jan. 26, 2017, 9:17 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/scripts/post-user-creation-hook.sh, line 34 > > <https://reviews.apache.org/r/55987/diff/2/?file=1616602#file1616602line34> > > > > I think using `$3` would be better, unless this one will remain the > > last one if new parameters are introduced in the future. > > Laszlo Puskas wrote: > As a convention (imposed by myself :) ) the uer should be always the last > parameter. The number of parameters may change depending on the security > type, so having a wired value is a bit problematic.
In that case it's fine. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55987/#review163162 ----------------------------------------------------------- On Jan. 26, 2017, 6:03 p.m., Laszlo Puskas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55987/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 6:03 p.m.) > > > Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-19726 > https://issues.apache.org/jira/browse/AMBARI-19726 > > > Repository: ambari > > > Description > ------- > > The post user creation hook had wired the **hdfs** user, user homes were > created in the name of this user. > In case of customized clusters this didn;t work due to permssion issues. > > The solution is to get the proper hdfs_user from the configureation and > access the dfs as this user. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/hooks/users/UserHookParams.java > 6970dcc > > ambari-server/src/main/java/org/apache/ambari/server/hooks/users/UserHookService.java > c4ff1e4 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/CsvFilePersisterService.java > fe6bf35 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerAction.java > e713128 > ambari-server/src/main/resources/scripts/post-user-creation-hook.sh ee8d2d1 > > ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java > 293b22a > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java > f5cdf48 > > Diff: https://reviews.apache.org/r/55987/diff/ > > > Testing > ------- > > Unit tests running. > Manual testing underway > > > Thanks, > > Laszlo Puskas > >
