-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56029/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Sumit Mohanty.
Bugs: AMBARI-19751
https://issues.apache.org/jira/browse/AMBARI-19751
Repository: ambari
Description
-------
AMBARI-19751: Credential Store params should be in the command json for RESTART
** Issue **
When a service that is enabled for credential store is restarted, credential
store information is not in the command JSON.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
8b851acafda4b1b1b5dd596a451075f3468bba59
Diff: https://reviews.apache.org/r/56029/diff/
Testing
-------
** 1. mvn clean install -DskipTests **
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [9.871s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.038s]
[INFO] Ambari Web ........................................ SUCCESS [56.127s]
[INFO] Ambari Views ...................................... SUCCESS [1.122s]
[INFO] Ambari Admin View ................................. SUCCESS [8.229s]
[INFO] utility ........................................... SUCCESS [0.278s]
[INFO] ambari-metrics .................................... SUCCESS [0.670s]
[INFO] Ambari Metrics Common ............................. SUCCESS [3.574s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.016s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.215s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.398s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.744s]
[INFO] Ambari Metrics Storm Sink (Legacy) ................ SUCCESS [1.669s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [10.225s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.190s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [0.989s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [1:17.210s]
[INFO] Ambari Server ..................................... SUCCESS [3:00.174s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1.879s]
[INFO] Ambari Agent ...................................... SUCCESS [31.880s]
[INFO] Ambari Client ..................................... SUCCESS [0.062s]
[INFO] Ambari Python Client .............................. SUCCESS [0.738s]
[INFO] Ambari Groovy Client .............................. SUCCESS [2.263s]
[INFO] Ambari Shell ...................................... SUCCESS [0.057s]
[INFO] Ambari Python Shell ............................... SUCCESS [1.576s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [0.802s]
[INFO] ambari-logsearch .................................. SUCCESS [0.371s]
[INFO] Ambari Logsearch Appender ......................... SUCCESS [0.162s]
[INFO] Ambari Logsearch Portal ........................... SUCCESS [9.786s]
[INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [4.780s]
[INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.766s]
[INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.147s]
[INFO] Ambari Logsearch Integration Test ................. SUCCESS [0.385s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:57.097s
[INFO] Finished at: Fri Jan 27 10:08:25 PST 2017
[INFO] Final Memory: 326M/1149M
[INFO] ------------------------------------------------------------------------
** 2. mvn test **
[Tests are running. Will be updated with results.]
** 3. Manual tests **
Verified the change on a VM. Command JSON now contains the following:
"hive.server2.table.type.mapping": "CLASSIC",
"hive.metastore.pre.event.listeners":
"org.apache.hadoop.hive.ql.security.authorization.AuthorizationPreEventListener",
"hive.metastore.failure.retries": "24",
"hadoop.security.credential.provider.path":
"jceks://file/var/lib/ambari-agent/cred/conf/hive/hive-site.jceks",
"roleCommand": "CUSTOM_COMMAND",
"credentialStoreEnabled": "true",
"hostLevelParams": {
"agent_stack_retry_on_unavailability": "false",
"stack_name": "HDP",
"group_list": "[\"zeppelin\",\"hadoop\",\"users\"]",
"host_sys_prepped": "false",
"ambari_db_rca_username": "mapred",
"current_version": "2.5.3.0-37",
"jdk_name": "jdk-8u77-linux-x64.tar.gz",
"mysql_jdbc_url":
"http://c6401.ambari.apache.org:8080/resources//mysql-connector-java.jar";,
"repo_info":
"[{\"baseUrl\":\"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.5.3.0\",\"osType\":\"redhat6\",\"repoId\":\"HDP-2.5\",\"repoName\":\"HDP\",\"defaultBaseUrl\":\"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.5.0.0\",\"latestBaseUrl\":\"http://public-repo-1.hortonworks.com/HDP/centos6/2.x/updates/2.5.3.0\",\"baseSaved\":true,\"unique\":true},{\"baseUrl\":\"http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos6\",\"osType\":\"redhat6\",\"repoId\":\"HDP-UTILS-1.1.0.21\",\"repoName\":\"HDP-UTILS\",\"defaultBaseUrl\":\"http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos6\",\"latestBaseUrl\":\"http://public-repo-1.hortonworks.com/HDP-UTILS-1.1.0.21/repos/centos6\",\"baseSaved\":true,\"unique\":false}]";,
"custom_command": "RESTART",
Thanks,
Nahappan Somasundaram
