----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55921/#review163462 -----------------------------------------------------------
contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java (line 100) <https://reviews.apache.org/r/55921/#comment234944> returning null here does not help, it will cover up some bugs somewhere else. throw an exception. contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java (line 112) <https://reviews.apache.org/r/55921/#comment234945> same here as well. returning null here does not help, it will cover up some bugs somewhere else. throw an exception. contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js (line 356) <https://reviews.apache.org/r/55921/#comment234947> I don't get the idea of generating X-XSRF-HEADER on client side. CSRF tokens are generated on serverside and clients resend it. Also as far as I know ambari does not checks for this token. Please explain its use or remove if not required. contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js (line 962) <https://reviews.apache.org/r/55921/#comment234949> there is no 'else' part to this 'if'. it may stuck the code execution. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs (line 131) <https://reviews.apache.org/r/55921/#comment234950> extract this constant into a constants file to conform with i18n specs. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs (line 346) <https://reviews.apache.org/r/55921/#comment234951> extract this constant into a constants file to conform with i18n specs. contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs (line 316) <https://reviews.apache.org/r/55921/#comment234952> extract this constant into a constants file to conform with i18n specs. - Nitiraj Rathore On Jan. 25, 2017, 10:45 a.m., Padma Priya N wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55921/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 10:45 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-19610 > https://issues.apache.org/jira/browse/AMBARI-19610 > > > Repository: ambari > > > Description > ------- > > Modified backend to support import of draft versions and added methods in > front end to parse the imported draft version. > > > Diffs > ----- > > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java > f7c1936 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > d029c39 > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFileInfo.java > 6dbf30e > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java > 289e68b > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java > 7ce6081 > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 2e0dadb > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > bba7793 > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 422253d > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > c682ea9 > contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js > c6c0421 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > f5eb6e7 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 8b42447 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 296463d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 1758946 > > Diff: https://reviews.apache.org/r/55921/diff/ > > > Testing > ------- > > Manual > > > Thanks, > > Padma Priya N > >
