> On Jan. 30, 2017, 11:29 a.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java, > > line 47 > > <https://reviews.apache.org/r/56013/diff/2/?file=1618935#file1618935line47> > > > > Please make sure tests pass on `trunk`, too, not only on `branch-2.5`. > > > > ``` > > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ > > ambari-server --- > > [INFO] Starting audit... > > [ERROR] > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java:47: > > 'com.google.inject.AbstractModule' should be separated from previous > > imports. [ImportOrder] > > Audit done. > > ```
thanks, fixed - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56013/#review163493 ----------------------------------------------------------- On Jan. 30, 2017, 1:10 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56013/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 1:10 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Robert Levas. > > > Bugs: AMBARI-19741 > https://issues.apache.org/jira/browse/AMBARI-19741 > > > Repository: ambari > > > Description > ------- > > fixing filed tests > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerActionTest.java > e756491 > > Diff: https://reviews.apache.org/r/56013/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Eugene Chekanskiy > >
