> On Jan. 30, 2017, 6:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/scripts/Ambaripreupload.py, line 141 > > <https://reviews.apache.org/r/56077/diff/1/?file=1618965#file1618965line141> > > > > Remove the hardcoding of "/usr/hdp". > > Use stack_root instead.
stack_root is get from /configurations/cluster-env/stack_root or script.py. Neither Ambaripreupload.py uses script.py nor any configuration. This is a simple script for for pre-creation which has all the configs hardcoded in it. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56077/#review163538 ----------------------------------------------------------- On Jan. 30, 2017, 1:24 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56077/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 1:24 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-19776 > https://issues.apache.org/jira/browse/AMBARI-19776 > > > Repository: ambari > > > Description > ------- > > > Diffs > ----- > > ambari-server/src/main/resources/scripts/Ambaripreupload.py 0e25a2a > > Diff: https://reviews.apache.org/r/56077/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
