----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56189/#review163975 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 930) <https://reviews.apache.org/r/56189/#comment235480> Lets add a test that goes through this condition. This one has low chance of coverage from system tests as hosts used are fairly powerful. So we should have a test with hosts in the order of 3-4 GB ram and 1-2 cores and verify the output from stack advisor. ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py (line 3584) <https://reviews.apache.org/r/56189/#comment235479> Why did these values change - were they not being set before? - Sumit Mohanty On Feb. 2, 2017, 12:41 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56189/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 12:41 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-19827 > https://issues.apache.org/jira/browse/AMBARI-19827 > > > Repository: ambari > > > Description > ------- > > HSI caluclations fails on cluster with small memory. Fixed the calulations > for that. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > fe9737a > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > fe58217 > > Diff: https://reviews.apache.org/r/56189/diff/ > > > Testing > ------- > > Python UT tests fixed and Passes. > Tested on cluster. > > > Thanks, > > Swapan Shridhar > >
