> On Feb. 3, 2017, 4:47 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java, > > line 195 > > <https://reviews.apache.org/r/56264/diff/1/?file=1622831#file1622831line195> > > > > The count for appId will get incremented for every metric, leading to > > wrong values.
Very good point. Made slight chnages which should mitigate this. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56264/#review164125 ----------------------------------------------------------- On Feb. 3, 2017, 5:09 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56264/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 5:09 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty. > > > Bugs: AMBARI-19858 > https://issues.apache.org/jira/browse/AMBARI-19858 > > > Repository: ambari > > > Description > ------- > > {quote} > live_hosts => # count of total hosts reporting > metrics > live_hosts & appId = <appId> => # count of hosts hosting this appId > {quote} > > Where appId = { namenode, datanode, hbase ... etc } > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 8d567ce > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricAppAggregator.java > d7b0d55 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java > 6f3d8bc > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java > 7a74e24 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecondTest.java > 58d908a > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml > 81fa4c7 > > Diff: https://reviews.apache.org/r/56264/diff/ > > > Testing > ------- > > mvn test passed for ambari-metrics. > > > Thanks, > > Sid Wagle > >
