----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56381/#review164498 -----------------------------------------------------------
Ship it! Ship It! - Denys Buzhor On Feb. 7, 2017, 11:16 a.m., Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56381/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:16 a.m.) > > > Review request for Ambari and Denys Buzhor. > > > Bugs: AMBARI-19888 > https://issues.apache.org/jira/browse/AMBARI-19888 > > > Repository: ambari > > > Description > ------- > > * Install ambari > * Register new version > * Install it (install should fail) > * Go to {{#/main/admin/stack/versions}} > * Click "Upgrade" for this version > * Popup with checks appears > * Click on link to see what checks failed > > *AR* A lot of warning about undefined variables appear: > {noformat} > WARNING: Watching an undefined global, Ember expects watched globals to be > setup by the time the run loop is flushed, check for typos > {noformat} > > > Diffs > ----- > > ambari-web/app/templates/common/modal_popups/cluster_check_dialog.hbs > 88d8eaf > ambari-web/app/views/common/modal_popups/cluster_check_popup.js a2f6f83 > ambari-web/test/models/service_test.js 5bd0cf8 > ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js > 71e602a > > Diff: https://reviews.apache.org/r/56381/diff/ > > > Testing > ------- > > 20326 passing (22s) > 153 pending > > > Thanks, > > Oleg Nechiporenko > >
