----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56407/#review164633 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java (line 229) <https://reviews.apache.org/r/56407/#comment236401> Shouldn't this be `commands = hostRoleCommandDAO.mergeAll(commands);` to reflect the managed entities? - Attila Doroszlai On Feb. 7, 2017, 11:15 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56407/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:15 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Sandor > Magyari, and Sid Wagle. > > > Bugs: AMBARI-19904 > https://issues.apache.org/jira/browse/AMBARI-19904 > > > Repository: ambari > > > Description > ------- > > When a command fails the all the other pending commands that belong to the > same request are aborted. In order the cluster state to be correctly > reflected the cluster state has to be recalculated for each aborted command > from all stages of the request. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java > 8aef70d > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 7837a7b > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > dabcb98 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > ade625a > > Diff: https://reviews.apache.org/r/56407/diff/ > > > Testing > ------- > > Manually tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" > command failing on at least one agent. > > Unit testing: > mvn test -DskipPythonTests -am -pl ambari-server > > Results : > > Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39 > > > Thanks, > > Sebastian Toader > >
