----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review164829 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java (line 136) <https://reviews.apache.org/r/56418/#comment236621> Madhu, As we discussed, it looks like getting the entire ServiceComponentInfo is expensive. If I query /api/v1/clusters/<cluster-name>/services/<service-name>/components/<component-name> it takes a long time. When exporting blueprint since we will be loading all service components we will have significant perf impact. Lets add filters to only get required fields for ServiceComponent serviceComponentNode.getObject().add("ServiceComponentInfo/cluster_name"); serviceComponentNode.getObject().add("ServiceComponentInfo/service_name"); serviceComponentNode.getObject().add("ServiceComponentInfo/component_name"); serviceComponentNode.getObject().add("ServiceComponentInfo/recovery_enabled"); - Jayush Luniya On Feb. 8, 2017, 12:52 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56418/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 12:52 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Robert > Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-19909 > https://issues.apache.org/jira/browse/AMBARI-19909 > > > Repository: ambari > > > Description > ------- > > Export Blueprints does not contain the settings object and hence the > credential store values > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java > 1a9ea91 > > Diff: https://reviews.apache.org/r/56418/diff/ > > > Testing > ------- > > Issued > http://c6401.ambari.apache.org:8080/api/v1/clusters/credential?format=blueprint > command to ensure that the settings object is present. > Resultant blueprint has the following object added: > "settings" : [ > { > "recovery_settings" : [ > { > "recovery_enabled" : "true" > } > ] > }, > { > "service_settings" : [ > { > "name" : "OOZIE", > "credential_store_enabled" : "true" > }, > { > "recovery_enabled" : "true", > "name" : "HIVE", > "credential_store_enabled" : "true" > }, > { > "recovery_enabled" : "true", > "name" : "HDFS" > }, > { > "recovery_enabled" : "true", > "name" : "AMBARI_METRICS" > } > ] > }, > { > "component_settings" : [ > { > "recovery_enabled" : "true", > "name" : "METRICS_COLLECTOR" > }, > { > "recovery_enabled" : "true", > "name" : "SECONDARY_NAMENODE" > }, > { > "recovery_enabled" : "true", > "name" : "WEBHCAT_SERVER" > } > ] > } > ] > > > Thanks, > > Madhuvanthi Radhakrishnan > >
