----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56483/#review164891 -----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/services/query.js (line 83) <https://reviews.apache.org/r/56483/#comment236733> can this be put into jobs service. Also it would be more usable if this returns job object in resolve. Also if error we should check for status "cancelled". This will happen if user cancels the job from hive view UI or yarn UI or otherwise cancels a running job. - Nitiraj Rathore On Feb. 9, 2017, 9:16 a.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56483/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 9:16 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19931 > https://issues.apache.org/jira/browse/AMBARI-19931 > > > Repository: ambari > > > Description > ------- > > Minor JS issue > > > Diffs > ----- > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/services/query.js b484c74 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8ee8e87 > > Diff: https://reviews.apache.org/r/56483/diff/ > > > Testing > ------- > > manuualy tested > > > Thanks, > > Pallav Kulshreshtha > >
