----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56488/#review164902 -----------------------------------------------------------
I guess alert-message is a good candidate for this, rather than introducing a modal. This is inline with what was happening in the old version of the view. Please fix it. - DIPAYAN BHOWMICK On Feb. 9, 2017, 11:25 a.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56488/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 11:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19938 > https://issues.apache.org/jira/browse/AMBARI-19938 > > > Repository: ambari > > > Description > ------- > > Added a modal for error. > > > Diffs > ----- > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 8ee8e87 > > Diff: https://reviews.apache.org/r/56488/diff/ > > > Testing > ------- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
