> On Feb. 8, 2017, 6:15 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 2243 > > <https://reviews.apache.org/r/56452/diff/1/?file=1627727#file1627727line2243> > > > > This can probably be simplified since we only really care the the > > pattern is something like: > > > > ``` > > ${...} > > ``` > > > > What is in the middle of the curly brackets is irrelevant since the > > entire string is replaced and restored in its entirety.
I prefer to keet in same as java code. - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56452/#review164720 ----------------------------------------------------------- On Feb. 8, 2017, 5:28 p.m., Eugene Chekanskiy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56452/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 5:28 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-19927 > https://issues.apache.org/jira/browse/AMBARI-19927 > > > Repository: ambari > > > Description > ------- > > Problem consist in breaking proxyuser hosts properties with placeholders from > kerberos.json during "Add service" wizard. > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/stack_advisor.py d4b9ab7 > > Diff: https://reviews.apache.org/r/56452/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Eugene Chekanskiy > >
