> On Фев. 9, 2017, 3:08 п.п., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java, > > line 296 > > <https://reviews.apache.org/r/56451/diff/3/?file=1628560#file1628560line296> > > > > Would it be easier/cleaner to use an enum for the protocol? I'm sure > > there's already one created somewhere for HTTP vs HTTPS
No enum as of now. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56451/#review164926 ----------------------------------------------------------- On Фев. 9, 2017, 4:20 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56451/ > ----------------------------------------------------------- > > (Updated Фев. 9, 2017, 4:20 п.п.) > > > Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Sid Wagle, and > Vitalyi Brodetskyi. > > > Bugs: AMBARI-19345 > https://issues.apache.org/jira/browse/AMBARI-19345 > > > Repository: ambari > > > Description > ------- > > Enable storm ui for https as per below document. > http://storm.apache.org/releases/1.0.1/SECURITY.html > Storm UI works fine and connect successfully using https. > However ambari alert for storm UI breaks, also ambari server keeps trying to > fetch REST metrics using http instead of https. > > > Diffs > ----- > > > ambari-funtest/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > 7c149bb > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java > 8c23fe0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 8f0d218 > ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json > b2b0404 > ambari-server/src/main/resources/common-services/STORM/0.9.1/alerts.json > 842538d > ambari-server/src/main/resources/common-services/STORM/0.9.1/metrics.json > 43ed608 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/quicklinks/quicklinks.json > 492f0a0 > ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json > d9a11b2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java > 8455484 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 4dffea8 > > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/STORM/metrics.json > 7c149bb > > Diff: https://reviews.apache.org/r/56451/diff/ > > > Testing > ------- > > Unit and manual tests passed. > > > Thanks, > > Dmytro Sen > >
