> On Feb. 9, 2017, 7:01 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml, > > line 26 > > <https://reviews.apache.org/r/56511/diff/1/?file=1628669#file1628669line26> > > > > Also make this change for YARN 3.0.0.3.0, including in its Service > > Advisor > > Vitalyi Brodetskyi wrote: > Why do we need to add these changes for 3.0.0? As i know yarn-site will > got this properties by inheritance from HDP-2.6. Similar situation with > stack_advisor, in every HDP stack advisor we are calling previous HDP > recommendations. Beside this, i don't see stack_advisor.py files at all. > Probably we should add separate jira for 3.0.0 to create stack_advisor and > test it?
We've already copied the internals of Stack Advisor for ZK, HDFS, and YARN from HDP 2.0.6-2.6 into Service Advisors. So any further changes we make to those services in older Stack Advisors must also be included in the new Service Advisor. YARN has it in common-services/YARN/3.0.0.3.0/service_advisor.py - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56511/#review164972 ----------------------------------------------------------- On Feb. 9, 2017, 6:55 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56511/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 6:55 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmytro Sen, Sumit Mohanty, and > Sid Wagle. > > > Bugs: AMBARI-19947 > https://issues.apache.org/jira/browse/AMBARI-19947 > > > Repository: ambari > > > Description > ------- > > We requires admin enables YARN preemption to make sure LLAP daemon can be > launched in a shared cluster. > And > yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled=true > need to be set to make preemption can happen under a fragmented cluster. > So once admin enables preemption, we can automatically set > yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled > to true. > This option > (yarn.scheduler.capacity.ordering-policy.priority-utilization.underutilized-preemption.enabled) > only supported by HDP-2.6 and after, it has no effect on HDP 2.5 and before. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-site.xml > 555768e > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 957d625 > > Diff: https://reviews.apache.org/r/56511/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
