-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56563/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Siddharth
Seth.
Bugs: AMBARI-19971
https://issues.apache.org/jira/browse/AMBARI-19971
Repository: ambari
Description
-------
**(1). Use the correct value for Node(s) used for running LLAP Daemon(s).**
- **Existing :** While starting LLAP, it was not taken into account removing
the Nodes used for SLider and Tez AM from 'num_llap_nodes' value, before using
it for starting LLAP by passing 'num_llap_nodes''s value to --instances
parameter.
- **Fix:** Introduced new config 'num_llap_nodes_for_llap_daemons' which has
the updated value substracting the nodes used by Tez and SLider AM's.
**(2). Set 'num_llap_nodes' calculated value only for non Ambari managed
queue.**
**Fix:** With AMBARI-19814 patch, UI shows 'num_llap_nodes' slider as READ only
for non Ambari managed queue for LLAP. We will be setting the calculated
'num_llap_nodes' slider value only for non-Ambari managed queue. For Ambari
managed queue named 'llap', user has the liberty of entering the value. We may
end up using less nodes than that, as part of calculation, but we dont want to
override the User entered value.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
1f1d9a8
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
a5618ca
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
e636e0c
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
99b6776
ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/hive-interactive-env.xml
af656f4
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py ec56bad
Diff: https://reviews.apache.org/r/56563/diff/
Testing
-------
- Python UT's updated. Passes.
-
- Tested on cluster manually.
Test where 'num_llap_nodes_for_llap_daemons' caluclated is different from
'num_llap_nodes'
==========================================================================================
- YARN min container size and YARN NM node size : 12 GB
- 'num_llap_nodes_for_llap_daemons' can be <= 'num_llap_nodes'.
**Screenshot showing 'num_llap_nodes'** : num_llap_nodes.png
**Screenshot showing 'num_llap_nodes_for_llap_daemons'** :
num_llap_nodes_for_llap_daemons.png
'num_llap_nodes_for_llap_daemons' config value is used as value for
"--instances" in below comamnd, used to start LLAP.
=======================================================================================================================================
/usr/hdp/current/hive-server2-hive2/bin/hive --service llap
--slider-am-container-mb 12288 --size 12288m --cache 9216m --xmx 2457m
--loglevel INFO --output
/var/lib/ambari-agent/tmp/llap-slider2017-02-10_21-31-47 --slider-placement 0
--skiphadoopversion --skiphbasecp --instances 3 --logger query-routing --args "
-XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA
-XX:+AggressiveOpts -XX:InitiatingHeapOccupancyPercent=80
-XX:MaxGCPauseMillis=200 -XX:MetaspaceSize=1024m"
=======================================================================================================================================
=======================================================================================================================================
File Attachments
----------------
num_llap_nodes
https://reviews.apache.org/media/uploaded/files/2017/02/10/a0c9e06f-1f1e-4ac4-bff7-e0900e4ad599__Screen_Shot_2017-02-10_at_1.43.45_PM.png
num_llap_nodes_for_llap_daemons
https://reviews.apache.org/media/uploaded/files/2017/02/10/fc9ff535-e4b7-4085-b39d-0b4951a4d176__Screen_Shot_2017-02-10_at_1.44.23_PM.png
Thanks,
Swapan Shridhar
