> On Feb. 11, 2017, 3:15 p.m., Nitiraj Rathore wrote: > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js, > > line 83 > > <https://reviews.apache.org/r/56572/diff/1/?file=1630725#file1630725line83> > > > > is this false a typo. if it is please correct and ship
No, this is for cancelling bubbling. - Pallav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165248 ----------------------------------------------------------- On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2017, 10:26 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19975 > https://issues.apache.org/jira/browse/AMBARI-19975 > > > Repository: ambari > > > Description > ------- > > created visual explain detail component > > > Diffs > ----- > > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain-detail.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 6551974 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 4238d43 > > Diff: https://reviews.apache.org/r/56572/diff/ > > > Testing > ------- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
