----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56606/#review165373 -----------------------------------------------------------
contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 51) <https://reviews.apache.org/r/56606/#comment237216> Please check, seems like typo. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 24) <https://reviews.apache.org/r/56606/#comment237207> spelling? contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 30) <https://reviews.apache.org/r/56606/#comment237215> Move these to the service or function as constants as described in the other comment contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 125) <https://reviews.apache.org/r/56606/#comment237214> Too much of tez related logic inside a route, can you move this to a stateless service or utility functions. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 236) <https://reviews.apache.org/r/56606/#comment237213> In a pure ember way routes should not contain view logic. Please fix this. contrib/views/hive20/src/main/resources/ui/app/services/job-data.js (line 21) <https://reviews.apache.org/r/56606/#comment237212> Why is this service required? contrib/views/hive20/src/main/resources/ui/app/services/jobs.js (line 39) <https://reviews.apache.org/r/56606/#comment237211> Why are you sending job model object when _fetchDummyResult() expects the job id. - DIPAYAN BHOWMICK On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56606/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 6:52 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19989 > https://issues.apache.org/jira/browse/AMBARI-19989 > > > Repository: ambari > > > Description > ------- > > As per the parity with Hive View 1.5, allow user to traverse to tez view from > the query page after executing a query. > > > Diffs > ----- > > contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js > a25adc7 > contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 > contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > 88202ff > contrib/views/hive20/src/main/resources/ui/app/services/job-data.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 5b2b5c2 > > Diff: https://reviews.apache.org/r/56606/diff/ > > > Testing > ------- > > Manual testing done > > > Thanks, > > venkat sairam > >
