-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56663/#review165508
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 183)
<https://reviews.apache.org/r/56663/#comment237348>

    Doc.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 191)
<https://reviews.apache.org/r/56663/#comment237346>

    You can use {} here for the log parameter.



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 202)
<https://reviews.apache.org/r/56663/#comment237347>

    You can use {} here for the log parameter.


- Jonathan Hurley


On Feb. 14, 2017, 9:09 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56663/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 9:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20010
>     https://issues.apache.org/jira/browse/AMBARI-20010
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> 1)Deploy cluster
> 2) Enable AMS Distr. mode
> 2)Make ambari only upgrade
> 
> *Actual result:* Critical alert: 'Percent JournalNodes Available' appears 
> after upgrade from ambari 2.2.2.0 to 2.5.0.0
> 
>    {
>       "href" : "http://host1:8080/api/v1/clusters/cl1/alerts/129";,
>       "Alert" : {
>         "cluster_name" : "cl1",
>         "component_name" : null,
>         "definition_id" : 60,
>         "definition_name" : "journalnode_process_percent",
>         "firmness" : "HARD",
>         "host_name" : null,
>         "id" : 129,
>         "instance" : null,
>         "label" : "Percent JournalNodes Available",
>         "latest_timestamp" : 1485911969646,
>         "maintenance_state" : "OFF",
>         "occurrences" : 1,
>         "original_timestamp" : 1485911969646,
>         "repeat_tolerance" : 1,
>         "repeat_tolerance_remaining" : 0,
>         "scope" : "SERVICE",
>         "service_name" : "HDFS",
>         "state" : "CRITICAL",
>         "text" : "affected: [3], total: [3]"
>       }
>     },
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  1f93f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  cee490b 
> 
> Diff: https://reviews.apache.org/r/56663/diff/
> 
> 
> Testing
> -------
> 
> Unit test + manual tests
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to