-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 2:38 p.m.)
Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert
Levas, and Sebastian Toader.
Changes
-------
- replaced collection with set
- removed setter
Bugs: AMBARI-19984
https://issues.apache.org/jira/browse/AMBARI-19984
Repository: ambari
Description
-------
Running ambari-upgrade multiple times cause an exception due to violation of
unique database constraint (the same RoleAuthorization can be added multiple
times to admin permissions).
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PermissionEntity.java
fb01cca
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/internal/InternalAuthenticationToken.java
8e69004
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
4b33bcd
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
1e68f9d
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
7fb8867
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
0cd4f12f
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
cee490b
Diff: https://reviews.apache.org/r/56599/diff/
Testing
-------
Added new unittest that checks if adding RoleAuthorization is idempotent.
Tested manually:
- installed ambari 2.4
- upgraded to ambari 2.5
- set version back to 2.4 by running: update metainfo set metainfo_value =
'2.4.0' where metainfo_key = 'version';
- upgraded to ambari 2.5 again
- started ambari-server checked the UI
Existing tests ran clealy
----------------------------------------------------------------------
Ran 465 tests in 15.977s
Tests run: 4915, Failures: 0, Errors: 0, Skipped: 39
Thanks,
Attila Magyar
