----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56656/#review165519 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Feb. 14, 2017, 11:49 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56656/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 11:49 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20006 > https://issues.apache.org/jira/browse/AMBARI-20006 > > > Repository: ambari > > > Description > ------- > > Hiding the External Solr button may cause an issue, if the cluster was > installed via blueprint, without the stack advisor used. In this case the > value is stuck at false, and as the button is hidden it can't even turned on. > > also > - removed some unused code > - moved some non project specific code from LogSearch to a new utility class > called WebUtil > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java > 70053d2 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java > 86c1edd > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java > b15ae43 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java > ace278f > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java > 81935d4 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/WebUtil.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java > fdda542 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchSecurityContextFormationFilter.java > b427749 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchUsernamePasswordAuthenticationFilter.java > 24ec2d4 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 0bdf319 > > Diff: https://reviews.apache.org/r/56656/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
