----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56706/#review165708 -----------------------------------------------------------
Fix it, then Ship it! Overall, the patch looks fine to me, just a minor question about the hard-coded configuration for the number of shards. This hard-coding may be fine, since the Solr instance is external in this case, but I just wanted to verify that this was done intentionally, since perhaps there is no other way to obtain the configuration at this point. Thanks. ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 1032) <https://reviews.apache.org/r/56706/#comment237570> Should the number of shards be hard-coded here? - Robert Nettleton On Feb. 15, 2017, 1:09 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56706/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 1:09 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20022 > https://issues.apache.org/jira/browse/AMBARI-20022 > > > Repository: ambari > > > Description > ------- > > Allow the choice to install Log Search without a portal, i.e. to install only > Log Feeders which load the entries into an external solr which are viewable > via an external portal. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 245a94d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > fecd802 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 5e0fa5e > > Diff: https://reviews.apache.org/r/56706/diff/ > > > Testing > ------- > > Tested two local Vagrant clusters. > > > Thanks, > > Miklos Gergely > >
