----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56627/#review165711 -----------------------------------------------------------
Fix it, then Ship it! Overall, the patch looks fine, but I do have some concerns about whether this scenario should be treated as a failure condition, or if the exception mentioned in this review is a symptom of another bug. Could you please add Sandor Magyari to this review, as he is another expert in this area of the code? It would be good to get a second opinion on this, to make sure I'm interpreting this correctly. Thanks. ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java (line 236) <https://reviews.apache.org/r/56627/#comment237573> I have some concerns about this change. While on the surface it would appear that this is the correct handling of this Blueprint deployment scenario, I'm a little concerned that this would preclude the following scenario: 1. Blueprint is POST-ed with 4 host-groups 2. Cluster Creation occurs, matching 3 hosts to 3 of the 4 host groups. 3. At a later point, an Add Host REST call might be made, to add a new worker node based on the hostgroup that is not matched in the initial deployment. I might be mis-understanding the intent of the original code, so we should probably have another reviewing take a look as well to confirm. - Robert Nettleton On Feb. 14, 2017, 12:37 a.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56627/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 12:37 a.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-19991 > https://issues.apache.org/jira/browse/AMBARI-19991 > > > Repository: ambari > > > Description > ------- > > Cluster creation REST API request gets accepted when, cluster template does > not list all the host_groups mentioned in the blueprint. But cluster > deployment fails showing error message in the logs > Caused by: java.lang.IllegalArgumentException: > TopologyManager.ConfigureClusterTask - prerequisites for config request > processing not yet satisfied > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:908) > at > org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:889) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java > d0a4df9 > > ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java > 1f31d05 > > Diff: https://reviews.apache.org/r/56627/diff/ > > > Testing > ------- > > Tested manually, updated test cases > > > Thanks, > > Amruta Borkar > >
