----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56678/#review165744 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java (line 769) <https://reviews.apache.org/r/56678/#comment237600> Can you break out the value and the equality check into 2 different lines - makes it easier to debug. Also, if the value isn't present, this will throw a NPE, right? Can you use StringUtils to ensure a safe comparison? ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java (line 771) <https://reviews.apache.org/r/56678/#comment237601> Should there be a default minimum that we don't go below? Just dividing by 2 seems a little strict, especially if the values are already low. ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml (line 301) <https://reviews.apache.org/r/56678/#comment237598> Should we capitalize this, or at least make it more descriptive? Something like, "Service Check Type" or "Service Check Level" - Jonathan Hurley On Feb. 14, 2017, 3:07 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56678/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 3:07 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-20017 > https://issues.apache.org/jira/browse/AMBARI-20017 > > > Repository: ambari > > > Description > ------- > > Right now, Ambari has a timeout of 5-10 mins for Service Checks. > We need to ensure service checks pass in less than 3 mins for all services. > > This means we need to potentially use a different configuration property if > one doesn't exist already so that QE can set it during the Ambari devdeploy > tests (in order to speed up the tests). > > This will likely result in bugs in either the Ambari python scripts or the > actual services, for which we will create Jiras and assign to the appropriate > stack team. > > This patch implements cluster_env/strict_service_check_type property. > Possible values are minimal (handled inside service check, runs shorter > service check action) and full (default action). If value is minimal, I also > reduce service check timeout when generating command on server in 2 times. > This way we adapt to service check timeouts that may be different for > different services. If service check takes 9 minutes of 10-minute timeout to > pass on our non-busy cluster, then it will probably take more then 10 minutes > on customers real cluster, and that is bad thing (bug). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > b601893 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 13d0993 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml > 3af8f08 > > Diff: https://reviews.apache.org/r/56678/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
