----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56710/#review165756 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java (line 905) <https://reviews.apache.org/r/56710/#comment237618> We shouldn't be hardcoding service names or config types in a check like this. If this is preventing the user from starting Ambari Server, then we should make this type of check be a warning as opposed to a hard error, or annotate a service or config-type with a tag to relax its validation in this check. Please add Jayush to the code review. - Alejandro Fernandez On Feb. 15, 2017, 3:13 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56710/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 3:13 p.m.) > > > Review request for Ambari and Dmitro Lisnichenko. > > > Bugs: AMBARI-20024 > https://issues.apache.org/jira/browse/AMBARI-20024 > > > Repository: ambari > > > Description > ------- > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 878d0fa > > Diff: https://reviews.apache.org/r/56710/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
