----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56708/#review165769 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java (line 21) <https://reviews.apache.org/r/56708/#comment237629> I suggest to rename this class to StatusMessage, because it is the message of a status, and not the status of a message. - Miklos Gergely On Feb. 15, 2017, 2:44 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56708/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 2:44 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-20023 > https://issues.apache.org/jira/browse/AMBARI-20023 > > > Repository: ambari > > > Description > ------- > > add delete endpoint for logsearch. > the actual queries can be used for that just with DELETE command. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java > 86c1edd > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java > 0568fd7 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java > caf0636 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java > 2dc0ef7 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java > f960250 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java > d5b6525 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java > 40247a8 > > Diff: https://reviews.apache.org/r/56708/diff/ > > > Testing > ------- > > testing done. > > > Thanks, > > Oliver Szabo > >
