----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56743/#review165859 -----------------------------------------------------------
Fix it, then Ship it! Overall, I think the patch is fine, but some modifications or further investigation might be required to determine how the hosts in the simulation should be named. Could you please add Yusaku, Alejandro, and Sid to this review? ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java (line 83) <https://reviews.apache.org/r/56743/#comment237691> I'm not sure if this will work in the context of the 3000-node cluster effort, since the ambari-agent will simulate multiple hosts as wel. Perhaps we should allow for a user to either specify the hostnames to use, or maybe specify a pattern or prefix to use in the host naming. For the sake of consistency, and for debugging these larger test clusters, it might be better to be able to correlate between the hostnames used by the ambari-agent simulator and the hostnames used by the LogFeeder simulator. - Robert Nettleton On Feb. 16, 2017, 9:54 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56743/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 9:54 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-20038 > https://issues.apache.org/jira/browse/AMBARI-20038 > > > Repository: ambari > > > Description > ------- > > The number of simulators set via logfeeder.simulate.input_number should work > as imitating separate hosts, having separate queues pushing data from to the > solr. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 24651ba > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigBlock.java > 47ddc51 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > 684f3c4 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java > be97a52 > > Diff: https://reviews.apache.org/r/56743/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
