----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review165942 -----------------------------------------------------------
Ship it! Ship It! - Laszlo Puskas On Feb. 17, 2017, 3:16 p.m., Attila Magyar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56783/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 3:16 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-20063 > https://issues.apache.org/jira/browse/AMBARI-20063 > > > Repository: ambari > > > Description > ------- > > After enabling kerberos kafka sets secure ACLs on certain znodes. These > secure ACLs should be removed by ambari during dekerberization. > > Note that the znode names are hardcoded in the params.py because AFAIK they > are also hardcoded in kafka. I'm still waiting for a kafka developer to > confirm this. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py > 0901730 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 1d3a195 > > Diff: https://reviews.apache.org/r/56783/diff/ > > > Testing > ------- > > Manually: > - created cluster with kafka > - enabled kerberos > - checked that acls on kafka znodes are secure > - disabled kerberos > - checked that acls on kafka znodes are 'world:anyone:crdwa' > > Ran 271 tests in 7.521s > OK > ---------------------------------------------------------------------- > Total run:1173 > Total errors:0 > Total failures:0 > ---------------------------------------------------------------------- > Ran 451 tests in 99.286s > OK > Results : > Tests run: 4925, Failures: 0, Errors: 0, Skipped: 39 > > > Thanks, > > Attila Magyar > >
