-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56799/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-20071
https://issues.apache.org/jira/browse/AMBARI-20071
Repository: ambari
Description
-------
The metrics sink prints lots of such messages in Hadoop daemons log every
second, which makes logs rotates and purge fast.
BEFORE PATCH
2017-02-16 19:05:48,896 INFO??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:refreshCollectorsFromConfigured(419)) -
Collector ctr-e129-1487033772569-2546-01-000004.hwx.site is not longer live.
Removing it from list of know live collector hosts : []
2017-02-16 19:05:48,896 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:findPreferredCollectHost(399)) - Couldn't
find any live collectors. Returning null
2017-02-16 19:05:48,896 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:emitMetrics(227)) - No live collector to send
metrics to. Metrics to be sent will be discarded.
2017-02-16 19:05:50,901 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:findLiveCollectorHostsFromKnownCollector(476))
- Unable to connect to collector to find live nodes.
2017-02-16 19:05:50,901 INFO??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:refreshCollectorsFromConfigured(419)) -
Collector ctr-e129-1487033772569-2546-01-000004.hwx.site is not longer live.
Removing it from list of know live collector hosts : []
2017-02-16 19:05:50,901 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:findPreferredCollectHost(399)) - Couldn't
find any live collectors. Returning null
2017-02-16 19:05:50,902 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:emitMetrics(227)) - No live collector to send
metrics to. Metrics to be sent will be discarded.
2017-02-16 19:06:48,896 WARN??timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:findLiveCollectorHostsFromKnownCollector(476))
- Unable to connect to collector to find live nodes.
AFTER PATCH
2017-02-17 19:49:28,224 INFO timeline.HadoopTimelineMetricsSink
(HadoopTimelineMetricsSink.java:init(80)) - Initializing Timeline metrics sink.
2017-02-17 19:49:28,224 INFO timeline.HadoopTimelineMetricsSink
(HadoopTimelineMetricsSink.java:init(98)) - Identified hostname =
avijayan-ams-1.openstacklocal, serviceName = datanode
2017-02-17 19:49:28,380 INFO timeline.HadoopTimelineMetricsSink
(HadoopTimelineMetricsSink.java:init(123)) - No suitable collector found.
2017-02-17 19:49:28,393 INFO impl.MetricsSinkAdapter
(MetricsSinkAdapter.java:start(206)) - Sink timeline started
2017-02-17 19:50:38,518 INFO timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:emitMetrics(230)) - No live collector to send
metrics to. Metrics to be sent will be discarded. This message will be skipped
for the next 20 times.
2017-02-17 19:53:28,712 INFO timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:emitMetrics(230)) - No live collector to send
metrics to. Metrics to be sent will be discarded. This message will be skipped
for the next 20 times.
2017-02-17 19:57:18,524 INFO timeline.HadoopTimelineMetricsSink
(AbstractTimelineMetricsSink.java:emitMetrics(230)) - No live collector to send
metrics to. Metrics to be sent will be discarded. This message will be skipped
for the next 20 times.
Diffs
-----
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
f5a02e4
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
1936977
Diff: https://reviews.apache.org/r/56799/diff/
Testing
-------
Manually tested.
mvn clean test on ambari-metrics-hadoop-sink.
Thanks,
Aravindan Vijayan
