----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56903/#review166264 -----------------------------------------------------------
Fix it, then Ship it! ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java (line 430) <https://reviews.apache.org/r/56903/#comment238180> Not a good habit to return the Stream reference, rather read the file and return the output from the method. - Sid Wagle On Feb. 21, 2017, 11:16 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56903/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 11:16 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-20103 > https://issues.apache.org/jira/browse/AMBARI-20103 > > > Repository: ambari > > > Description > ------- > > Reduce AMS HBase metrics through whitelist. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-assembly/pom.xml 4c7ed41 > > ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector-windows.xml > 1ea6c46 > ambari-metrics/ambari-metrics-assembly/src/main/assembly/collector.xml > 0997b48 > > ambari-metrics/ambari-metrics-timelineservice/conf/unix/amshbase_metrics_whitelist > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/conf/windows/amshbase_metrics_whitelist > PRE-CREATION > ambari-metrics/ambari-metrics-timelineservice/pom.xml 0c4bdf8 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > b249d05 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > 7bbd5aa > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java > d05353d > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java > 049d473 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java > ab6c34a > > ambari-metrics/ambari-metrics-timelineservice/src/test/resources/test_data/amshbase_metrics_whitelist.dat > PRE-CREATION > > Diff: https://reviews.apache.org/r/56903/diff/ > > > Testing > ------- > > mvn clean test on ambari-metrics. > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
