----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/#review166327 -----------------------------------------------------------
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js (line 72) <https://reviews.apache.org/r/56915/#comment238276> It looks like this might break if some more internal keys are added to ember objects in later versions. Can you rely on something like : JSON.parse(JSON.stringify(unsupportedProperties)) to get plain js object. - Nitiraj Rathore On Feb. 22, 2017, 6:32 a.m., Padma Priya N wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56915/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 6:32 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20107 > https://issues.apache.org/jira/browse/AMBARI-20107 > > > Repository: ambari > > > Description > ------- > > The issue is because the jsog object id is appended to the xml. Fixed by > excluding jsog object id in the unsupported properties. > > > Diffs > ----- > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js > d09de7d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs > fae2d3d > > Diff: https://reviews.apache.org/r/56915/diff/ > > > Testing > ------- > > Manual Testing > > > Thanks, > > Padma Priya N > >
