-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56950/
-----------------------------------------------------------

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-20120
    https://issues.apache.org/jira/browse/AMBARI-20120


Repository: ambari


Description
-------

Perform an HDP upgrade from 2.3 to 2.4 where Ranger is an installed service.

*Result*
Observed errors while updating below Ranger service configs:
Updating configuration usersync-log4j
Updating configuration admin-log4j

{code}
Server action failed
Could not find desired config type with name admin-log4j
{code}

- Both {{usersync-log4j}} and {{admin-log4j}} appear in Ranger 0.6.0 which is 
first used by HDP 2.5. Therefore, the configuration changes should simply be 
removed from upgrades on stacks before HDP 2.5

- Additionally, I found {{RANGER_TAGSYNC}} references in HDP 2.3 and HDP 2.4. 
This component also first appeared in Ranger 0.6.0, so it should also be 
removed from earlier upgrade packs.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 13a6c36 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
6572bbb 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
8589e2d 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 52421d9 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 280000d 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
 d675986 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
b662b28 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
b53ff23 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
9917ee1 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
14feab6 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 f093cb1 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
 e856288 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
2a3e6b2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
f736796 

Diff: https://reviews.apache.org/r/56950/diff/


Testing
-------

Performed upgrades from HDP 2.3 to 2.4 and then to 2.5. Observed the new 
configurations were created in Ambari 2.5 and no errors were seen during 
upgrade.


Thanks,

Jonathan Hurley

Reply via email to