-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56957/#review166494
-----------------------------------------------------------


Ship it!




Ship It!

- Oleg Nechiporenko


On Feb. 23, 2017, 8:50 a.m., Denys Buzhor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56957/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 8:50 a.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-20123
>     https://issues.apache.org/jira/browse/AMBARI-20123
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following items should be fixed:
> 
> * After the user clicks on "Next", need to disable the button right away and 
> show the spin animation in the button like we already do for Install Wizard
> * While a step is still loading, do not allow the user to click Next (the 
> button should be disabled until the step has completed loading)
> * Download CSV request can take some time, need to show spin animation and 
> prevent additional clicks during data loading
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js c0decfc 
>   ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 992fd34 
>   ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 8e5abd5 
>   ambari-web/app/controllers/main/admin/kerberos/step5_controller.js 9cb75e0 
>   ambari-web/app/mixins/wizard/wizardProgressPageController.js d426eda 
>   ambari-web/app/routes/add_kerberos_routes.js fe21dae 
>   ambari-web/app/styles/common.less 94a5cd3 
>   ambari-web/app/templates/common/button_progress.hbs PRE-CREATION 
>   ambari-web/app/templates/common/progress.hbs fce5641 
>   ambari-web/app/templates/main/admin/kerberos/step1.hbs 19e5596 
>   ambari-web/app/templates/main/admin/kerberos/step2.hbs c17347c 
>   ambari-web/app/templates/main/admin/kerberos/step3.hbs 6e2ea57 
>   ambari-web/app/templates/main/admin/kerberos/step4.hbs 1e6f956 
>   ambari-web/app/templates/main/admin/kerberos/step5.hbs c0cdc00 
>   ambari-web/app/views.js 9addd91 
>   ambari-web/app/views/common/buttons/button_progress_view.js PRE-CREATION 
>   ambari-web/app/views/common/buttons/wizard_buttons.js PRE-CREATION 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> 3181fda 
>   ambari-web/test/controllers/main/admin/kerberos/step2_controller_test.js 
> 2e603da 
> 
> Diff: https://reviews.apache.org/r/56957/diff/
> 
> 
> Testing
> -------
> 
> 20375 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Reply via email to