> On Фев. 22, 2017, 6:03 п.п., Sid Wagle wrote: > > ambari-common/src/main/python/ambari_commons/network.py, line 45 > > <https://reviews.apache.org/r/56926/diff/1/?file=1642450#file1642450line45> > > > > Why is this harcoded to tlsv1? Is there a best practice guidance here? > > Dmytro Sen wrote: > TLSv1 is more secure than SSLv23, so we're trying TLS and fallback to > SSL. TLSv1 works for CentOS and Suse, before the patch it was always SSLv23.
This would guarantee that we are providing secure protocol where it's possible and use old implementation if necessary. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56926/#review166383 ----------------------------------------------------------- On Фев. 23, 2017, 1:14 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56926/ > ----------------------------------------------------------- > > (Updated Фев. 23, 2017, 1:14 п.п.) > > > Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-20115 > https://issues.apache.org/jira/browse/AMBARI-20115 > > > Repository: ambari > > > Description > ------- > > On the node grafana is running. > > # cat /var/run/ambari-metrics-grafana/grafana-server.pid > 26593 > # ps aux | grep 26593 > root 20057 0.0 0.0 5712 824 pts/0 R+ 16:12 0:00 grep 26593 > ams 26593 0.0 0.0 102032 12904 ? Sl 01:19 0:11 > /usr/lib/ambari-metrics-grafana/bin/grafana-server > --pidfile=/var/run/ambari-metrics-grafana/grafana-server.pid > --config=/etc/ambari-metrics-grafana/conf/ams-grafana.ini > cfg:default.paths.data=/var/lib/ambari-metrics-grafana > cfg:default.paths.logs=/var/log/ambari-metrics-grafana > > > How ever after enabling WE when we tried to start all services ambari reported > > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py", > line 77, in <module> > AmsGrafana().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 313, in execute > method(env) > File > "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py", > line 58, in start > create_ams_datasource() > File > "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py", > line 239, in create_ams_datasource > response = perform_grafana_get_call(GRAFANA_DATASOURCE_URL, server) > File > "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py", > line 72, in perform_grafana_get_call > raise Fail("Ambari Metrics Grafana update failed due to: %s" % str(ex)) > resource_management.core.exceptions.Fail: Ambari Metrics Grafana update > failed due to: [Errno 1] _ssl.c:491: error:1407742E:SSL > routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/network.py b5b1cd6 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > a751330 > > Diff: https://reviews.apache.org/r/56926/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Dmytro Sen > >
