> On Feb. 24, 2017, 1:38 a.m., Jaimin Jetly wrote: > > ambari-web/app/controllers/experimental.js, line 38 > > <https://reviews.apache.org/r/57004/diff/1/?file=1646551#file1646551line38> > > > > $.merge(response, App.get('supports')) returns back the first argument > > passed. As a result the application behavior remains the same as it was > > before this patch > > > > Please use $.extend instead of $.merge.
$.merge is for array, will adjust to $.extend - Richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57004/#review166629 ----------------------------------------------------------- On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57004/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 11:52 p.m.) > > > Review request for Ambari and Jaimin Jetly. > > > Bugs: AMBARI-20158 > https://issues.apache.org/jira/browse/AMBARI-20158 > > > Repository: ambari > > > Description > ------- > > Always show host combo search. > Merge instead of overwrite support list after loading user-pref. > > > Diffs > ----- > > ambari-web/app/config.js 6afa810 > ambari-web/app/controllers/experimental.js 8b93761 > ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df > > Diff: https://reviews.apache.org/r/57004/diff/ > > > Testing > ------- > > Manually tested on live cluster. > All unit tests passed. > 20375 passing (23s) > 153 pending > > > Thanks, > > Richard Zang > >
