> On Feb. 24, 2017, 8:25 a.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json, > > line 109 > > <https://reviews.apache.org/r/56997/diff/1/?file=1646442#file1646442line109> > > > > Make sure the user-defined (artifacts/kerberos_descriptor) is updated > > and any configuration changes are performed using the appropriate > > UpgradeCatalog class. > > Robert Levas wrote: > For example see > `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKerberosDescriptorArtifact` > > Oliver Szabo wrote: > thanks, somehow we should check as well which HDP is used, because these > kerberos descriptor updates only needed if a specific HDP is installed
Your changes in revision 2 look good. Since /STORM/NIMBUS/nimbus_server is not in the older stacks (`common-services/STORM/0.9.1/kerberos.json`), this will work ok. However if you wanted to be really sure, checking that the stack would be nice... but that is problematic since we don't really have a good idea of all the stacks that could be out there. Maybe there is a way to identitiy which version of STORM is being used instead. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56997/#review166699 ----------------------------------------------------------- On Feb. 24, 2017, 11:08 a.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56997/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 11:08 a.m.) > > > Review request for Ambari, Miklos Gergely, Mugdha Varadkar, Robert Levas, and > Robert Nettleton. > > > Bugs: AMBARI-20152 > https://issues.apache.org/jira/browse/AMBARI-20152 > > > Repository: ambari > > > Description > ------- > > Use storm principal and keytab for ranger plugin instead of nimbus ones. > In storm code, storm user will be used globally anyway, ranger plugin will > use that. In Ambari 2.4 that not caused any issues, but from Ambari 2.5, Solr > authorization is supported, that can cause if storm is authenticated with the > worng user, it wont be able to access the ranger audit collection. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > bfab0fe > ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json > fecef7c > > Diff: https://reviews.apache.org/r/56997/diff/ > > > Testing > ------- > > done. > > > Thanks, > > Oliver Szabo > >
