On Feb. 24, 2017, 11:27 a.m., Sebastian Toader wrote: > > Should any unit tests be updated? > > Sebastian Toader wrote: > Existing unit tests passed fine with the change. Is there already a > mechanism in Ambari that can be used to test if certain records are persisted > within a transaction or not?
I don't know if there is such a thing... DB-related unit testing isn't in my wheelhouse. :| - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56987/#review166716 ----------------------------------------------------------- On Feb. 24, 2017, 10:25 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56987/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 10:25 a.m.) > > > Review request for Ambari, Attila Doroszlai, Robert Levas, and Sandor Magyari. > > > Bugs: AMBARI-19929 > https://issues.apache.org/jira/browse/AMBARI-19929 > > > Repository: ambari > > > Description > ------- > > Move the persisting of > TopologyRequest/TopologyLogicalRequest/TopologyHostRequest records into a > single transaction to esnure consistency accross these records. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 9ef32b5 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > ab56844 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > a26624e > > Diff: https://reviews.apache.org/r/56987/diff/ > > > Testing > ------- > > Performed manual testing covering cluster creation using Blueprint and than > cluster upscaling. > > Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39 > > > Thanks, > > Sebastian Toader > >
